Skip to content

chore: librarian generate pull request: 20260323T221520Z#1518

Closed
ohmayr wants to merge 1 commit intomainfrom
librarian-20260323T221520Z
Closed

chore: librarian generate pull request: 20260323T221520Z#1518
ohmayr wants to merge 1 commit intomainfrom
librarian-20260323T221520Z

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Mar 23, 2026

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
feat: include cache updates and routing hint into BeginTransaction and Commit request/response respectively

PiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field routing_hint in messages .google.spanner.v1.ResultSet and .google.spanner.v1.PartialResultSet are changed

PiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment in message .google.spanner.v1.TransactionOptions.ReadWrite.ReadLockMode is changed

PiperOrigin-RevId: 878019893
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@5c9602db
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field transaction_tag in message .google.spanner.v1.RequestOptions is changed

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field params in message .google.spanner.v1.PartitionQueryRequest is changed

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field param_types in message .google.spanner.v1.PartitionQueryRequest is changed

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: include cache updates into the ResultSet response

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field commit_timestamp in message .google.spanner.v1.BatchWriteResponse is changed

PiperOrigin-RevId: 865546011
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@8d30990f
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
chore: adjust initial_poll_delay for CreateDatabase and UpdateDatabaseDdl LRO operations

PiperOrigin-RevId: 853884590
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@136a2c43
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add Secure Parameters to the ClientContext

PiperOrigin-RevId: 853323071
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@211d22fa
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add a ClientContext field to Spanner requests

PiperOrigin-RevId: 853323071
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@211d22fa
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Update high_priority_cpu_utilization_percent in AutoscalingConfig to be Optional and clarify its behavior when not specified

PiperOrigin-RevId: 845819318
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@6e20492a
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: Exposing total CPU related fields in AutoscalingConfig

PiperOrigin-RevId: 845819318
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@6e20492a
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: minor update for Spanner Location API

PiperOrigin-RevId: 834841888
Library-IDs: google-cloud-spanner
Source-link: googleapis/googleapis@ded7ed1e
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@a17b84ad
(exclusive) and
googleapis/googleapis@5c9602db
(inclusive).

Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209

@ohmayr ohmayr requested review from a team as code owners March 23, 2026 22:15
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Mar 23, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 23, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the google-cloud-spanner client library, incorporating several new features and significant documentation improvements. Key enhancements include adding location-aware routing hints and cache updates to transaction and result set operations, introducing more flexible autoscaling configurations with total CPU utilization targets, and enabling secure parameter passing via a new ClientContext field. These changes aim to improve performance, provide finer control over Spanner instances, and clarify API usage.

Highlights

  • Enhanced Transaction and Request Management: Introduced cache_update and routing_hint fields to BeginTransaction and Commit requests/responses, and ResultSet responses to improve location awareness and caching.
  • Advanced Autoscaling Configuration: Added total_cpu_utilization_percent and related disable flags to AutoscalingConfig for more granular control over instance autoscaling.
  • Secure Parameters in ClientContext: Implemented ClientContext with secure_context to allow passing secure parameters with Spanner requests.
  • Documentation Clarifications: Updated comments for routing_hint, ReadLockMode, transaction_tag, params, param_types, and commit_timestamp across various Spanner API messages.
  • Build and Test Infrastructure Updates: Refined noxfile.py by removing pytest-asyncio and asyncio_mode=auto from pytest commands, and removed an unused generate session.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 23, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by the Librarian CLI, updates the Cloud Client Libraries from protos. The changes primarily consist of:

  • Updates to generated client code, including new fields, methods, and documentation reflecting the latest proto definitions.
  • Widespread import reordering for better style consistency.
  • Simplifications and improvements to the testing setup in noxfile.py.

I've found a few minor issues related to duplicated imports in several files, which were likely introduced by the generation process. I've left comments with suggestions to remove them. Other than that, the changes look good and are consistent with an automated generation process.

google/cloud/spanner_admin_database_v1/services/database_admin/async_client.py
from google.iam.v1 import iam_policy_pb2 # type: ignore
from google.iam.v1 import policy_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This import of google.longrunning.operations_pb2 is duplicated. Please remove one of them to keep the imports clean.

google/cloud/spanner_admin_database_v1/services/database_admin/client.py
from google.iam.v1 import iam_policy_pb2 # type: ignore
from google.iam.v1 import policy_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This import of google.longrunning.operations_pb2 is duplicated. Please remove one of them to keep the imports clean.

google/cloud/spanner_admin_instance_v1/services/instance_admin/async_client.py
from google.iam.v1 import iam_policy_pb2 # type: ignore
from google.iam.v1 import policy_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This import of google.longrunning.operations_pb2 is duplicated. Please remove one of them to keep the imports clean.

google/cloud/spanner_admin_instance_v1/services/instance_admin/client.py
from google.iam.v1 import iam_policy_pb2 # type: ignore
from google.iam.v1 import policy_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This import of google.longrunning.operations_pb2 is duplicated. Please remove one of them to keep the imports clean.

tests/unit/gapic/spanner_admin_database_v1/test_database_admin.py
from google.iam.v1 import options_pb2 # type: ignore
from google.iam.v1 import policy_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This import of google.longrunning.operations_pb2 is duplicated. Please remove one of them to keep the imports clean.

tests/unit/gapic/spanner_admin_instance_v1/test_instance_admin.py
from google.iam.v1 import options_pb2 # type: ignore
from google.iam.v1 import policy_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
from google.longrunning import operations_pb2 # type: ignore
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This import of google.longrunning.operations_pb2 is duplicated. Please remove one of them to keep the imports clean.

@ohmayr ohmayr added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 24, 2026
@ohmayr ohmayr closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sinhasubham sinhasubham

Labels

api: spanner Issues related to the googleapis/python-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ohmayr @sinhasubham